Re: [PATCH] misbehaviour of ext2_notify_change

Stephen C. Tweedie (sct@redhat.com)
Sun, 29 Aug 1999 16:56:30 +0100 (BST)


Hi,

On Sat, 28 Aug 1999 10:34:06 +0200, Matthias Riese
<punk@informatik.uni-bremen.de> said:

> Stumbled about this while updating ACL patch to 2.2.12:
> IMHO the flags in inode->u.ext2_i.i_flags arenīt
> exlusive, are they?

Correct. This exact same diff was sent to Alan a while ago but it seems
it didn't make 2.2.12. Alan, could you queue this for .13?

--Stephen

----------------------------------------------------------------
--- linux/fs/ext2/inode.c.bak Thu Jul 29 14:35:55 1999
+++ linux/fs/ext2/inode.c Thu Jul 29 14:36:18 1999
@@ -757,28 +757,28 @@
flags = iattr->ia_attr_flags;
if (flags & ATTR_FLAG_SYNCRONOUS) {
inode->i_flags |= MS_SYNCHRONOUS;
- inode->u.ext2_i.i_flags = EXT2_SYNC_FL;
+ inode->u.ext2_i.i_flags |= EXT2_SYNC_FL;
} else {
inode->i_flags &= ~MS_SYNCHRONOUS;
inode->u.ext2_i.i_flags &= ~EXT2_SYNC_FL;
}
if (flags & ATTR_FLAG_NOATIME) {
inode->i_flags |= MS_NOATIME;
- inode->u.ext2_i.i_flags = EXT2_NOATIME_FL;
+ inode->u.ext2_i.i_flags |= EXT2_NOATIME_FL;
} else {
inode->i_flags &= ~MS_NOATIME;
inode->u.ext2_i.i_flags &= ~EXT2_NOATIME_FL;
}
if (flags & ATTR_FLAG_APPEND) {
inode->i_flags |= S_APPEND;
- inode->u.ext2_i.i_flags = EXT2_APPEND_FL;
+ inode->u.ext2_i.i_flags |= EXT2_APPEND_FL;
} else {
inode->i_flags &= ~S_APPEND;
inode->u.ext2_i.i_flags &= ~EXT2_APPEND_FL;
}
if (flags & ATTR_FLAG_IMMUTABLE) {
inode->i_flags |= S_IMMUTABLE;
- inode->u.ext2_i.i_flags = EXT2_IMMUTABLE_FL;
+ inode->u.ext2_i.i_flags |= EXT2_IMMUTABLE_FL;
} else {
inode->i_flags &= ~S_IMMUTABLE;
inode->u.ext2_i.i_flags &= ~EXT2_IMMUTABLE_FL;
----------------------------------------------------------------

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/