Re: 2.1.120 broken on P5 SMP machines + fix

Linus Torvalds (torvalds@transmeta.com)
Sun, 6 Sep 1998 14:04:27 -0700 (PDT)


On Sun, 6 Sep 1998, Thomas Bogendoerfer wrote:
>
> On Sun, Sep 06, 1998 at 11:08:29AM -0700, Linus Torvalds wrote:
> > I think the real problem is that "set_intr_gate()" really should just know
> > about the F0 0F bug, and be able to insert stuff into the IDT regardless
> > of whether the workaround is active or not.
>
> I thought about that too. But when I looked at the assembler stuff of
> set_gate() I didn't want mess with it. Is there really a need for doing
> it in assembler ? Two wrapper functions unlock_idt() and lock_idt()
> around _set_gate should also work, but gives some overhead, which shouldn't
> be a problem.

The only reason for doing it in assembler is that that particular code is
from version 0.01 and before, and it has worked and nobody has felt
comfortable changing it..

I'll clean it up a bit for 2.1.121, because it also doesn't really make
sense to have it in a common header-file when it really isn't something
that people normally want to use..

Linus

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/faq.html