Re: New pre-patch (Re: [PATCH] kswapd fully sysctl tunable)

Manuel J. Galan (manolow@step.es)
Sun, 03 May 1998 15:59:45 +0100 (WEST)


-----BEGIN PGP SIGNED MESSAGE-----

On 03-May-98 David S. Miller wrote:
> Date: Sun, 3 May 1998 16:25:49 +0200 (CEST)
> From: Niels Kristian Bech Jensen <nkbj@image.dk>
>
> I can't get ppp-2.3.4 to build on my system (error building
> pppd/sys-linux.c.) I'll investigate further.
>
> As posted by another person on linux-kernel, the problem is the
> version number 100 in pre-100 Makefile, which breaks uname() under
> most GLIBC based systems. Quick fix is the change the version back to
> "99" in the toplevel Makefile.

Well I'll elaborete further, the problem is not in 'uname()' but in
incorrect comparisons using 'strcmp()' in several places of sys-linux.c.

...
if (strcmp(utsname.release, "2.1.16") >= 0)
...

That gives incorrect results with utsname.release = "2.1.100"

I've put a 'horrible hacked version' to solve this issue
@ ftp://ftp.ulpgc.es/pub/ulpgc/ppp-2.3.4/

- --
Manuel J. Galan
manolow@step.es

-----BEGIN PGP SIGNATURE-----
Version: PGPfreeware 5.0i for non-commercial use
Comment: Using RSA Key
Charset: noconv

iQEVAwUBNUyGYGD+APAfXUYjAQG2Mwf8Dy9cJqLoLSw90S+mr8yZmb50767yEhWu
iD+19fotqzdZX9uj5ePOpAFMYZ1nAQGMqZTJv/+GUqBfxcg5DS33CIU9k3XiG+Xz
hEPn/4ybUWtLL1+Q1Yw/muNMeYQ1k8WIuNYmtQOtXMHLcA3YKe4bU1OQXn8DzXOx
cYh3a+GWRmFcW1iYkxyCJWO3gQ5w/FkZuHQqOLGEYiutWfobw+sKJ0ZIq71/bEHq
pJRWqRWblemIFjMmEy2BqKSOWXF93wuXoTbDvW5kNeYwntlkYnbZEnhYycYUcgxP
ZkhgCfAyrYEOewULc2iGZcVrQ1P/xgkLlozGtZoBdHOUl14sSY4EjA==
=1BZ6
-----END PGP SIGNATURE-----

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu