Re: [PATCH] drivers/tty/serial: Remove unused function early_mcf_setup

[Geert Uytterhoeven]

On Tue, Feb 20, 2024 at 6:11 AM Jiri Slaby <jirislaby@xxxxxxxxxx> wrote:
> On 19. 02. 24, 17:40, Thomas Huth wrote:
> > Compiling a kernel for the ColdFire causes a compiler warning:
> >
> > drivers/tty/serial/mcf.c:473:12: warning: no previous prototype for
> >   ‘early_mcf_setup’ [-Wmissing-prototypes]
> >    473 | int __init early_mcf_setup(struct mcf_platform_uart *platp)
> >        |            ^~~~~~~~~~~~~~~
> >
> > This function seems to be completely unused, so let's remove it
> > to silence the warning.
>
> And it seems so since the driver addition in 2007 by:
> commit 49aa49bfd40d718095669c1c70c9d167b814e29b
> Author: Greg Ungerer <gerg@xxxxxxxxxxxx>
> Date:   Tue Oct 23 14:37:54 2007 +1000
>
>      m68knommu: new style ColdFire UART driver

Indeed.

Looks like the "changes to the ColdFire based m68knommu systems
to use a platform model at init, and this is used there" from [1]
never materialized on any public mailing list?

Greg: does it still make sense to add them? If not:
Reviewed-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>

[1] https://lore.kernel.org/all/47254BEB.2040609@xxxxxxxxxxxx/

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68korg

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds