Re: [PATCH v2] fpga: remove redundant checks for bridge ops

From: Marco Pagani
Date: Tue Feb 20 2024 - 05:25:30 EST




On 2024-02-18 05:04, Xu Yilun wrote:
> On Thu, Feb 01, 2024 at 04:57:12PM +0100, Marco Pagani wrote:
>> Commit 0d70af3c2530 ("fpga: bridge: Use standard dev_release for class
>> driver") introduced a check in fpga_bridge_register() that prevents
>> registering a bridge without ops, making checking on every call
>> redundant.
>>
>> v2:
>> - removed ops check also in state_show()
>
> Don't put the history in changelog.

You're right, sorry.

>
> I could fix it.
> Acked-by: Xu Yilun <yilun.xu@xxxxxxxxx>
>

Yes, please.

>>
>> Signed-off-by: Marco Pagani <marpagan@xxxxxxxxxx>
> ---
> v2:
> - XXXX
>
> This way the history could be discarded when apply.
>
>> ---
>> drivers/fpga/fpga-bridge.c | 8 ++++----
>> 1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/fpga/fpga-bridge.c b/drivers/fpga/fpga-bridge.c
>> index a024be2b84e2..79c473b3c7c3 100644
>> --- a/drivers/fpga/fpga-bridge.c
>> +++ b/drivers/fpga/fpga-bridge.c

[...]
Thanks,
Marco