Re: [PATCH] drivers/tty/serial: Remove unused function early_mcf_setup

[Jiri Slaby]

On 19. 02. 24, 17:40, Thomas Huth wrote:
> Compiling a kernel for the ColdFire causes a compiler warning:
>
> drivers/tty/serial/mcf.c:473:12: warning: no previous prototype for
>   ‘early_mcf_setup’ [-Wmissing-prototypes]
>    473 | int __init early_mcf_setup(struct mcf_platform_uart *platp)
>        |            ^~~~~~~~~~~~~~~
>
> This function seems to be completely unused, so let's remove it
> to silence the warning.

And it seems so since the driver addition in 2007 by:
commit 49aa49bfd40d718095669c1c70c9d167b814e29b
Author: Greg Ungerer <gerg@xxxxxxxxxxxx>
Date:   Tue Oct 23 14:37:54 2007 +1000

    m68knommu: new style ColdFire UART driver



Reviewed-by: Jiri Slaby <jirislaby@xxxxxxxxxx>

thanks,
--
js
suse labs