Re: [PATCH 0/6] Add PPE device tree node for Qualcomm IPQ SoC

From: Konrad Dybcio
Date: Wed Jan 10 2024 - 06:32:43 EST




On 1/10/24 12:20, Luo Jie wrote:
The PPE(packet process engine) hardware block is supported by Qualcomm
IPQ platforms, such as IPQ9574 and IPQ5332. The PPE includes the various
packet processing modules such as the routing and bridging flow engines,
L2 switch capability, VLAN and tunnels. Also included are integrated
ethernet MAC and PCS(uniphy), which is used to connect with the external
PHY devices by PCS.

This patch series enables support for the following DTSI functionality
for Qualcomm IPQ9574 and IPQ5332 chipsets.

1. Add PPE (Packet Processing Engine) HW support

2. Add IPQ9574 RDP433 board support, where the PPE is connected
with qca8075 PHY and AQ PHY.

3. Add IPQ5332 RDP441 board support, where the PPE is connected
with qca8386 and SFP

PPE DTS depends on the NSSCC clock driver below, which provides the
clocks for the PPE driver.
https://lore.kernel.org/linux-arm-msm/20230825091234.32713-1-quic_devipriy@xxxxxxxxxxx/
https://lore.kernel.org/linux-arm-msm/20231211-ipq5332-nsscc-v3-0-ad13bef9b137@xxxxxxxxxxx/

None of these describe (or even use) the compatible in the first
patch of this series ("qcom,ipq9574-ppe"). I didn't check the
subsequent ones, as I assume it's the same situtation, so this
is a NAK.

Lei Wei (2):
arm64: dts: qcom: ipq5332: Add RDP441 board device tree
arm64: dts: qcom: ipq9574: Add RDP433 board device tree

These two look unrelated?


Luo Jie (4):
arm64: dts: qcom: ipq9574: Add PPE device tree node
arm64: dts: qcom: ipq5332: Add PPE device tree node
arm64: dts: qcom: ipq5332: Add MDIO device tree
arm64: dts: qcom: ipq9574: Add MDIO device tree

Konrad