Re: [PATCH v7 4/5] iommu/arm-smmu: add ACTLR data and support for SM8550

[Bibek Kumar Patro]

On 1/10/2024 4:19 PM, Konrad Dybcio wrote:
> On 1/9/24 12:42, Bibek Kumar Patro wrote:
> > Add ACTLR data table for SM8550 along with support for
> > same including SM8550 specific implementation operations.
> >
> > Signed-off-by: Bibek Kumar Patro <quic_bibekkum@xxxxxxxxxxx>
> > ---
> [...]
>
> > +static const struct actlr_variant sm8550_actlr[] = {
> > +    { sm8550_apps_actlr_cfg, 0x15000000 },
> > +    { sm8550_gfx_actlr_cfg, 0x03da0000 },
> > +    {},
> > +};
>
> Please use C99 designated initializers and put the address first.

Noted, thanks for this input. Will take care of this in next patch.

Thanks & regards,
Bibek

> Konrad