Re: [PATCH] drm/mediatek/dp: Add the HDCP feature for DisplayPort

[CK Hu (胡俊光)]

Hi, Mac:

On Fri, 2023-11-24 at 16:53 +0800, mac.shen wrote:
> Add tee client application, HDCP 1.x and 2.x authentication for
> DisplayPort
> to support the HDCP feature.
> 
> Signed-off-by: mac.shen <mac.shen@xxxxxxxxxxxx>
> ---

[snip]

> +
> +void mdrv_dp_tx_hdcp1x_set_start_auth(struct mtk_hdcp_info
> *hdcp_info, bool enable)

The prefix 'mdrv' of each function seems redundant. So drop the prifix
'mdrv'.

Regards,
CK

> +{
> +	hdcp_info->hdcp1x_info.enable = enable;
> +
> +	if (enable) {
> +		hdcp_info->auth_status = AUTH_INIT;
> +		hdcp_info->hdcp1x_info.main_states =
> HDCP1X_main_state_A0;
> +		hdcp_info->hdcp1x_info.sub_states =
> HDCP1X_sub_FSM_IDLE;
> +	} else {
> +		hdcp_info->auth_status = AUTH_ZERO;
> +		hdcp_info->hdcp1x_info.main_states =
> HDCP1X_main_state_H2;
> +		hdcp_info->hdcp1x_info.sub_states =
> HDCP1X_sub_FSM_IDLE;
> +		tee_hdcp_enable_encrypt(hdcp_info, false, HDCP_NONE);
> +		mhal_dp_tx_hdcp1x_start_cipher(hdcp_info, false);
> +		tee_hdcp1x_soft_rst(hdcp_info);
> +	}
> +
> +	hdcp_info->hdcp1x_info.retry_count = 0;
> +}
> +