Re: [PATCH] drm/mediatek/dp: Add the HDCP feature for DisplayPort

[CK Hu (胡俊光)]

Hi, Mac:

On Fri, 2023-11-24 at 16:53 +0800, mac.shen wrote:
> Add tee client application, HDCP 1.x and 2.x authentication for
> DisplayPort
> to support the HDCP feature.
> 
> Signed-off-by: mac.shen <mac.shen@xxxxxxxxxxxx>
> ---

[snip]

> +
>  static int mtk_dp_probe(struct platform_device *pdev)
>  {
>  	struct mtk_dp *mtk_dp;
> @@ -2657,6 +2778,16 @@ static int mtk_dp_probe(struct platform_device
> *pdev)
>  	if (ret)
>  		return ret;
>  
> +	INIT_WORK(&mtk_dp->hdcp_work, mtk_dp_hdcp_handle);
> +	mtk_dp->hdcp_workqueue = create_workqueue("mtk_dp_hdcp_work");
> +	if (!mtk_dp->hdcp_workqueue) {
> +		dev_err(mtk_dp->dev, "failed to create hdcp work
> queue");
> +		return -ENOMEM;
> +	}
> +
> +	mtk_dp->hdcp_info.aux = &mtk_dp->aux;
> +	mtk_dp->hdcp_info.regs = mtk_dp->regs;

It's not necessary to duplicate aux and regs, so drop this.

Regards,
CK

> +
>  	mtk_dp->bridge.funcs = &mtk_dp_bridge_funcs;
>  	mtk_dp->bridge.of_node = dev->of_node;
>  	mtk_dp->bridge.type = mtk_dp->data->bridge_type;
>