Re: [PATCH] rhashtable: Better error message on allocation failure

From: Herbert Xu
Date: Thu Nov 23 2023 - 03:32:51 EST


On Wed, Nov 22, 2023 at 06:32:16PM -0500, Kent Overstreet wrote:
> Memory allocation failures print backtraces by default, but when we're
> running out of a rhashtable worker the backtrace is useless - it doesn't
> tell us which hashtable the allocation failure was for.
>
> This adds a dedicated warning that prints out functions from the
> rhashtable params, which will be a bit more useful.
>
> Signed-off-by: Kent Overstreet <kent.overstreet@xxxxxxxxx>
> Cc: Thomas Graf <tgraf@xxxxxxx>
> Cc: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
> ---
> lib/rhashtable.c | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)

Acked-by: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>

However, you'll need to repost this via netdev@xxxxxxxxxxxxxxx for
it to be merged.

Thanks,
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt