Re: [PATCH v3 1/2] dt-bindings: iio: frequency: add admfm2000

[Krzysztof Kozlowski]

On 23/11/2023 09:24, Paller, Kim Seer wrote:
>>>>> ---
>>>>> V2 -> V3: Adjusted indentation to resolve wrong indentation warning.
>>>>>           Changed node name to converter. Updated the descriptions to clarify
>>>>>           the properties.
>>>>
>>>>
>>>>> +title: ADMFM2000 Dual Microwave Down Converter
>>>>> +
>>>>> +maintainers:
>>>>> +  - Kim Seer Paller <kimseer.paller@xxxxxxxxxx>
>>>>> +
>>>>> +description:
>>>>> +  Dual microwave down converter module with input RF and LO frequency
>>>> ranges
>>>>> +  from 0.5 to 32 GHz and an output IF frequency range from 0.1 to 8 GHz.
>>>>> +  It consists of a LNA, mixer, IF filter, DSA, and IF amplifier for each down
>>>>> +  conversion path.
>>>>> +
>>>>> +properties:
>>>>> +  compatible:
>>>>> +    enum:
>>>>> +      - adi,admfm2000
>>>>> +
>>>>> +  switch1-gpios:
>>>>> +    items:
>>>>> +      - description:
>>>>> +          Setting B15 GPIO to high and B16 GPIO to low will result in channel
>> 1
>>>>> +          being in Direct IF mode.
>>>>> +      - description:
>>>>> +          Setting B15 GPIO to low and B16 GPIO to high will result in channel
>> 1
>>>>> +          being in Mixer mode.
>>>>
>>>> This still does not tell which one is B15 and which is B16. I am asking
>>>> this for third time.
>>>>
>>>> items:
>>>>   - description: B15 GPIO, when high (and B16 low) channel 1 is in
>>>> Direct IF mode
>>>
>>> I understand now, thank you. I was also wondering if this applies to the
>>> attenuation-gpios, or if I should keep it as is?
>>
>> Yes, something like this applies to all your properties with multiple
>> entries. You need to define the order.
> 
> Before I send a new patch/commit, could you please check this one if it is 
> properly defined?
> 
>   attenuation1-gpios:
>     items:
>       - description: C14 GPIO, when low (and C15, C16, D14, D15 high)
>           channel 1 attenuation is 1 dB.
>       - description: C15 GPIO, when low (and C14, C16, D14, D15 high)
>           channel 1 attenuation is 2 dB.
>       - description: C16 GPIO, when low (and C14, C15, D14, D15 high)
>           channel 1 attenuation is 4 dB.
>       - description: D14 GPIO, when low (and C14, C15, C16, D15 high)
>           channel 1 attenuation is 8 dB.
>       - description: D15 GPIO, when low (and C14, C15, C16, D14 high)
>           channel 1 attenuation is 16 dB.

This actually could be written in easier way like:

  attenuation1-gpios:
    description: |
      Choice of attenuation:
      C14 C15   ......
      1    0   0   0   - 1 dB
      0    1   0   0   - 2 dB
      ...
    items:
      - description: C14 GPIO
      - description: C15 GPIO
      - description: C16 GPIO
      - description: D14 GPIO
      - description: D15 GPIO

or whatever is easy to understand. The point is that you must define the
order of GPIOs and explain their meaning.

Best regards,
Krzysztof