Re: [PATCH] rhashtable: Better error message on allocation failure

From: Kent Overstreet
Date: Thu Nov 23 2023 - 18:58:56 EST


On Thu, Nov 23, 2023 at 04:32:47PM +0800, Herbert Xu wrote:
> On Wed, Nov 22, 2023 at 06:32:16PM -0500, Kent Overstreet wrote:
> > Memory allocation failures print backtraces by default, but when we're
> > running out of a rhashtable worker the backtrace is useless - it doesn't
> > tell us which hashtable the allocation failure was for.
> >
> > This adds a dedicated warning that prints out functions from the
> > rhashtable params, which will be a bit more useful.
> >
> > Signed-off-by: Kent Overstreet <kent.overstreet@xxxxxxxxx>
> > Cc: Thomas Graf <tgraf@xxxxxxx>
> > Cc: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
> > ---
> > lib/rhashtable.c | 9 +++++++--
> > 1 file changed, 7 insertions(+), 2 deletions(-)
>
> Acked-by: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
>
> However, you'll need to repost this via netdev@xxxxxxxxxxxxxxx for
> it to be merged.

Thanks!