Re: [PATCH v4 3/3] serial: core: Fix serial core controller port name to show controller id

From: Jiri Slaby
Date: Mon Jul 24 2023 - 05:06:44 EST


On 24. 07. 23, 10:55, Andy Shevchenko wrote:
On Mon, Jul 24, 2023 at 08:07:05AM +0300, Tony Lindgren wrote:
We are missing the serial core controller id for the serial core port
name. Let's fix the issue for sane /sys/bus/serial-core/devices, and to
avoid issues addressing serial ports later on.

...

- return dev_set_name(dev, "%s.%s.%d", type->name, dev_name(port->dev), id);
-}
+ if (type == &serial_ctrl_type)

...

+}

While at it, have you tried to use --patience when forming patches? Does it
make any (better) difference?

Or moving "struct device_type"s to one place in a separate patch might do the desired trick too ;).

--
js
suse labs