Re: [PATCH v4 3/3] serial: core: Fix serial core controller port name to show controller id

From: Tony Lindgren
Date: Mon Jul 24 2023 - 05:09:19 EST


* Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> [230724 08:56]:
> On Mon, Jul 24, 2023 at 08:07:05AM +0300, Tony Lindgren wrote:
> > We are missing the serial core controller id for the serial core port
> > name. Let's fix the issue for sane /sys/bus/serial-core/devices, and to
> > avoid issues addressing serial ports later on.
>
> ...
>
> > - return dev_set_name(dev, "%s.%s.%d", type->name, dev_name(port->dev), id);
> > -}
> > + if (type == &serial_ctrl_type)
>
> ...
>
> > +}
>
> While at it, have you tried to use --patience when forming patches? Does it
> make any (better) difference?

I'll check if it makes it more readable. Seems I need to also enable the
--patience option for myself for sending patches to avoid messing up things
like Reviewed-by tags :)

Tony