Re: [PATCH] m68k: q40: add missing spaces around '='

[Geert Uytterhoeven]

Hi Ran,

On Thu, Jul 20, 2023 at 5:54 AM <sunran001@xxxxxxxxxx> wrote:
> add missing spaces to clear checkpatch errors.
>
> ERROR: spaces required around that '=' (ctx:VxV)
>
> Signed-off-by: Ran Sun <sunran001@xxxxxxxxxx>

WARNING: From:/Signed-off-by: email name mismatch: 'From:
sunran001@xxxxxxxxxx' != 'Signed-off-by: Ran Sun
<sunran001@xxxxxxxxxx>'

> ---
>   arch/m68k/q40/q40ints.c | 10 +++++-----
>   1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/arch/m68k/q40/q40ints.c b/arch/m68k/q40/q40ints.c
> index 127d7ecdbd49..fdd6e48f4fe3 100644
> --- a/arch/m68k/q40/q40ints.c
> +++ b/arch/m68k/q40/q40ints.c
> @@ -132,10 +132,10 @@ static irqreturn_t q40_timer_int(int irq, void
> *dev_id)
>   {
>         ql_ticks = ql_ticks ? 0 : 1;
>         if (sound_ticks) {
> -               unsigned char sval=(sound_ticks & 1) ? 128-SVOL : 128+SVOL;
> +               unsigned char sval = (sound_ticks & 1) ? 128-SVOL : 128+SVOL;
>                 sound_ticks--;
> -               *DAC_LEFT=sval;
> -               *DAC_RIGHT=sval;
> +               *DAC_LEFT = sval;
> +               *DAC_RIGHT = sval;
>         }
>
>         if (!ql_ticks) {
> @@ -171,7 +171,7 @@ void q40_sched_init (void)
>
>   struct IRQ_TABLE{ unsigned mask; int irq ;};
>   #if 0
> -static struct IRQ_TABLE iirqs[]={
> +static struct IRQ_TABLE iirqs[] = {
>     {Q40_IRQ_FRAME_MASK,Q40_IRQ_FRAME},
>     {Q40_IRQ_KEYB_MASK,Q40_IRQ_KEYBOARD},
>     {0,0}};
> @@ -189,7 +189,7 @@ static struct IRQ_TABLE eirqs[] = {
>   };
>
>   /* complain only this many times about spurious ints : */
> -static int ccleirq=60;    /* ISA dev IRQs*/
> +static int ccleirq = 60;    /* ISA dev IRQs*/
>   /*static int cclirq=60;*/     /* internal */
>
>   /* FIXME: add shared ints,mask,unmask,probing.... */

This patch is whitespace-damaged, so it fails to apply.

These problems are present in all your patches, so something is
wrong in your workflow.  Please test your patches by running
scripts/checkpatch.pl, emailing them to yourself, and trying to
apply them.

Thanks!

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds