Re: [PATCH v2] perf stat: Add missing newline in pr_err messages

From: Arnaldo Carvalho de Melo
Date: Tue Jun 13 2023 - 15:45:19 EST


Em Tue, Jun 13, 2023 at 09:32:05AM +0800, Yang Jihong escreveu:
> On 2023/6/13 2:55, Arnaldo Carvalho de Melo wrote:
> > Em Sat, Jun 10, 2023 at 09:44:41AM +0000, Yang Jihong escreveu:
> > > The newline is missing for error messages in add_default_attributes()
> > >
> > > Before:
> > >
> > > # perf stat --topdown
> > > Topdown requested but the topdown metric groups aren't present.
> > > (See perf list the metric groups have names like TopdownL1)#
> > >
> > > After:
> > >
> > > # perf stat --topdown
> > > Topdown requested but the topdown metric groups aren't present.
> > > (See perf list the metric groups have names like TopdownL1)
> > > #
> > >
> > > In addition, perf_stat_init_aggr_mode() and perf_stat_init_aggr_mode_file()
> > > have the same problem, fixed by the way.
> >
> > Wait a bit till I push what I had to perf-tools-next, as it is not
> > applying right now:
> OK, I'm doing the patch based on the mainline, and if I need to do it based
> on the perf-tools-next branch, I'll reissue it.

For patches for the currente perf development cycle the perf-tools-next
branch of:

git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git

Should be used.

Hopefully soon we will transition to:

git://git.kernel.org/pub/scm/linux/kernel/git/perf-tools/perf-tools-next.git

And also:

git://git.kernel.org/pub/scm/linux/kernel/git/perf-tools/perf-tools.git

For fixes geared to the current merge window, when we are accepting just
fixes.

- Arnaldo