Re: [PATCH 4/8] perf vendor events arm64: Add default tags into topdown L1 metrics

[Ian Rogers]

On Wed, Jun 7, 2023 at 9:27 AM <kan.liang@xxxxxxxxxxxxxxx> wrote:
>
> From: Kan Liang <kan.liang@xxxxxxxxxxxxxxx>
>
> Add the default tags for ARM as well.
>
> Signed-off-by: Kan Liang <kan.liang@xxxxxxxxxxxxxxx>
> Cc: Jing Zhang <renyu.zj@xxxxxxxxxxxxxxxxx>
> Cc: John Garry <john.g.garry@xxxxxxxxxx>

Acked-by: Ian Rogers <irogers@xxxxxxxxxx>

Thanks,
Ian

> ---
>  tools/perf/pmu-events/arch/arm64/sbsa.json | 12 ++++++++----
>  1 file changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/tools/perf/pmu-events/arch/arm64/sbsa.json b/tools/perf/pmu-events/arch/arm64/sbsa.json
> index f678c37ea9c3..f90b338261ac 100644
> --- a/tools/perf/pmu-events/arch/arm64/sbsa.json
> +++ b/tools/perf/pmu-events/arch/arm64/sbsa.json
> @@ -2,28 +2,32 @@
>      {
>          "MetricExpr": "stall_slot_frontend / (#slots * cpu_cycles)",
>          "BriefDescription": "Frontend bound L1 topdown metric",
> -        "MetricGroup": "TopdownL1",
> +        "DefaultMetricgroupName": "TopdownL1",
> +        "MetricGroup": "Default;TopdownL1",
>          "MetricName": "frontend_bound",
>          "ScaleUnit": "100%"
>      },
>      {
>          "MetricExpr": "(1 - op_retired / op_spec) * (1 - stall_slot / (#slots * cpu_cycles))",
>          "BriefDescription": "Bad speculation L1 topdown metric",
> -        "MetricGroup": "TopdownL1",
> +        "DefaultMetricgroupName": "TopdownL1",
> +        "MetricGroup": "Default;TopdownL1",
>          "MetricName": "bad_speculation",
>          "ScaleUnit": "100%"
>      },
>      {
>          "MetricExpr": "(op_retired / op_spec) * (1 - stall_slot / (#slots * cpu_cycles))",
>          "BriefDescription": "Retiring L1 topdown metric",
> -        "MetricGroup": "TopdownL1",
> +        "DefaultMetricgroupName": "TopdownL1",
> +        "MetricGroup": "Default;TopdownL1",
>          "MetricName": "retiring",
>          "ScaleUnit": "100%"
>      },
>      {
>          "MetricExpr": "stall_slot_backend / (#slots * cpu_cycles)",
>          "BriefDescription": "Backend Bound L1 topdown metric",
> -        "MetricGroup": "TopdownL1",
> +        "DefaultMetricgroupName": "TopdownL1",
> +        "MetricGroup": "Default;TopdownL1",
>          "MetricName": "backend_bound",
>          "ScaleUnit": "100%"
>      }
> --
> 2.35.1
>