Em Sat, Jun 10, 2023 at 09:44:41AM +0000, Yang Jihong escreveu:OK, I'm doing the patch based on the mainline, and if I need to do it based on the perf-tools-next branch, I'll reissue it.
The newline is missing for error messages in add_default_attributes()
Before:
# perf stat --topdown
Topdown requested but the topdown metric groups aren't present.
(See perf list the metric groups have names like TopdownL1)#
After:
# perf stat --topdown
Topdown requested but the topdown metric groups aren't present.
(See perf list the metric groups have names like TopdownL1)
#
In addition, perf_stat_init_aggr_mode() and perf_stat_init_aggr_mode_file()
have the same problem, fixed by the way.
Wait a bit till I push what I had to perf-tools-next, as it is not
applying right now: