Re: [PATCH 2/2] dt-bindings: gnss: Add U-Blox Zed-F9

From: Krzysztof Kozlowski
Date: Mon May 08 2023 - 02:39:25 EST


On 08/05/2023 03:11, alison@xxxxxxxxxxxxx wrote:
> From: Alison Chaiken <achaiken@xxxxxxxxxxx>
>
> Add support for the U-Blox Zed-F9P GNSS device.
>
> Signed-off-by: Alison Chaiken <achaiken@xxxxxxxxxxx>
> ---

You miss versioning your paches and changelog here.

Also:

This is a friendly reminder during the review process.

It looks like you received a tag and forgot to add it.

If you do not know the process, here is a short explanation:
Please add Acked-by/Reviewed-by/Tested-by tags when posting new
versions. However, there's no need to repost patches *only* to add the
tags. The upstream maintainer will do that for acks received on the
version they apply.

https://elixir.bootlin.com/linux/v5.17/source/Documentation/process/submitting-patches.rst#L540

If a tag was not added on purpose, please state why and what changed.

Missing tag:
Acked-by: Rob Herring <robh@xxxxxxxxxx>


> Documentation/devicetree/bindings/gnss/u-blox,neo-6m.yaml | 1 +
> 1 file changed, 1 insertion(+)

Best regards,
Krzysztof