Re: [PATCH] arm64: dts: imx93: add wdog3 node

[Alexander Stein]

Hello,

thanks for the patch.

Am Freitag, 5. Mai 2023, 11:31:30 CEST schrieb Peng Fan (OSS):
> From: Peng Fan <peng.fan@xxxxxxx>
> 
> Add wdog3 node, then watchdog could be used.
> 
> Signed-off-by: Peng Fan <peng.fan@xxxxxxx>
> ---
>  arch/arm64/boot/dts/freescale/imx93.dtsi | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx93.dtsi
> b/arch/arm64/boot/dts/freescale/imx93.dtsi index e8d49660ac85..73ecd953ec8d
> 100644
> --- a/arch/arm64/boot/dts/freescale/imx93.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx93.dtsi
> @@ -344,6 +344,14 @@ mu2: mailbox@42440000 {
>  				status = "disabled";
>  			};
> 
> +			wdog3: wdog@42490000 {

I think this should be called 'watchdog@42490000'

> +				compatible = "fsl,imx93-wdt";
> +				reg = <0x42490000 0x10000>;
> +				interrupts = <GIC_SPI 79 
IRQ_TYPE_LEVEL_HIGH>;
> +				clocks = <&clk IMX93_CLK_WDOG3_GATE>;
> +				timeout-sec = <40>;

Should it be disabled it by default?

> +			};
> +
>  			tpm3: pwm@424e0000 {
>  				compatible = "fsl,imx7ulp-pwm";
>  				reg = <0x424e0000 0x1000>;

Is there a reason you just add watchdog3? There are 5 in total.

Best regards,
Alexander
-- 
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/