Re: [PATCH 6/5] generic: test ftruncate zeroes bytes after EOF

From: Matthew Wilcox
Date: Fri Feb 03 2023 - 08:13:35 EST


On Fri, Feb 03, 2023 at 11:57:11AM +0000, Johannes Thumshirn wrote:
> On 02.02.23 21:45, Matthew Wilcox (Oracle) wrote:
> > + fprintf(stderr, "Truncation did not zero new bytes:\n");
> > + for (i = 0; i < 5; i++)
> > + fprintf(stderr, "%#x ", buf[i]);
> > + fputc('\n', stderr);
> >
>
> [...]
>
> > +
> > +$here/src/truncate-zero $test_file > $seqres.full 2>&1 ||
> > + _fail "truncate zero failed!"
> > +
> Is '_fail' really needed here? truncate-zero will spit out an error message
> in case the truncation doesn't work.

I don't know what I'm doing. I totally cargo-culted 706 to make 707.
If someone wants to completely rewrite it, go ahead!