Re: [PATCH 6/5] generic: test ftruncate zeroes bytes after EOF

From: Johannes Thumshirn
Date: Fri Feb 03 2023 - 06:57:27 EST


On 02.02.23 21:45, Matthew Wilcox (Oracle) wrote:
> + fprintf(stderr, "Truncation did not zero new bytes:\n");
> + for (i = 0; i < 5; i++)
> + fprintf(stderr, "%#x ", buf[i]);
> + fputc('\n', stderr);
>

[...]

> +
> +$here/src/truncate-zero $test_file > $seqres.full 2>&1 ||
> + _fail "truncate zero failed!"
> +
Is '_fail' really needed here? truncate-zero will spit out an error message
in case the truncation doesn't work.