Re: [PATCH v5 09/10] arm64: dts: freescale: add initial apalis imx8 aka quadmax module support

[Marcel Ziswiler]

Hi Shawn

On Wed, 2023-02-01 at 04:01 +0100, Marcel Ziswiler wrote:

[snip]


> > > +/* Apalis UART1 */
> > > +&lpuart1 {
> > > +       dma-names = "","";
> > 
> > What is this for?
> 
> I guess that switches off DMA falling pack to PIO. Likely, there was an issue at one point in downstream. Let
> me re-test without it.

BTW: Upstream this indeed works just fine without this and I removed it in v6.

[snip]

> > > +&usbotg1 {
> > > +       adp-disable;
> > > +       ci-disable-lpm;
> > > +       hnp-disable;
> > > +       over-current-active-low;
> > > +       pinctrl-names = "default";
> > > +       pinctrl-0 = <&pinctrl_usbotg1>;
> > 
> > We generally want to put such generic properties before device specific
> > ones.
> 
> Okay.

Sorry, I missed the generally here. Let me re-work the device trees with this in mind adhering to hopefully all
the rules which apply and send a v7 ASAP.

> Thanks!

Thank you!

> > Shawn

Cheers

Marcel


[snip]