Re: [PATCH net-next] net/sched: cls_api: remove redundant 0 check in tcf_qevent_init()

From: shaozhengchao
Date: Wed Aug 31 2022 - 21:04:36 EST




On 2022/9/1 3:30, Jakub Kicinski wrote:
On Mon, 29 Aug 2022 15:17:20 +0800 Zhengchao Shao wrote:
tcf_qevent_parse_block_index() has been checked the value of block_index.

Please rephrase this:

tcf_qevent_parse_block_index() never returns a zero block_index.

Took me a while to figure out what you mean.

Therefore, it is unnecessary to check the value of block_index in
tcf_qevent_init().

Hi Jakub:
Thank you for your reply. I will send v2.

Zhengchao Shao