Re: [PATCH v2] comedi: sysfs: convert sysfs snprintf to sysfs_emit

From: zhangxuezhi3
Date: Wed Aug 31 2022 - 21:05:19 EST


On Wed, 31 Aug 2022 16:02:11 +0200
Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:

> On Wed, Aug 31, 2022 at 08:55:20PM +0800, Xuezhi Zhang wrote:
> > From: zhangxuezhi1 <zhangxuezhi1@xxxxxxxxxxx>
> >
> > Fix up all sysfs show entries to use sysfs_emit
>
> This says "what", but not "why".
>
> Please read the kernel documentation for how to write a good changelog
> text.
>
> >
> > Signed-off-by: Xuezhi Zhang <zhangxuezhi1@xxxxxxxxxxx>
> > ---
> > v2: use a proper name for the Signed-off-by line.
>
> Does not match the From: line :(
>
>
> thanks,
>
> greg k-h

OK, I see.

Thanks.