Re: [PATCH net-next] net/sched: cls_api: remove redundant 0 check in tcf_qevent_init()

From: Jakub Kicinski
Date: Wed Aug 31 2022 - 15:30:34 EST

Next message: kernel test robot: "Re: [PATCH v2 1/1] gpio: rockchip: Switch to use fwnode instead of of_node"
Previous message: Matthias Brugger: "Re: [PATCH v3 0/2] Add mt8186 mutex support for mdp3"
In reply to: Zhengchao Shao: "[PATCH net-next] net/sched: cls_api: remove redundant 0 check in tcf_qevent_init()"
Next in thread: shaozhengchao: "Re: [PATCH net-next] net/sched: cls_api: remove redundant 0 check in tcf_qevent_init()"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Mon, 29 Aug 2022 15:17:20 +0800 Zhengchao Shao wrote:
> tcf_qevent_parse_block_index() has been checked the value of block_index.

Please rephrase this:

tcf_qevent_parse_block_index() never returns a zero block_index.

Took me a while to figure out what you mean.

> Therefore, it is unnecessary to check the value of block_index in
> tcf_qevent_init().

Next message: kernel test robot: "Re: [PATCH v2 1/1] gpio: rockchip: Switch to use fwnode instead of of_node"
Previous message: Matthias Brugger: "Re: [PATCH v3 0/2] Add mt8186 mutex support for mdp3"
In reply to: Zhengchao Shao: "[PATCH net-next] net/sched: cls_api: remove redundant 0 check in tcf_qevent_init()"
Next in thread: shaozhengchao: "Re: [PATCH net-next] net/sched: cls_api: remove redundant 0 check in tcf_qevent_init()"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]