Re: [PATCH] video: fbdev: skeletonfb.c: Adding code to managing allocation error

[Geert Uytterhoeven]

On Sat, Jun 21, 2014 at 3:58 PM, Joe Perches <joe@xxxxxxxxxxx> wrote:
> (Adding Geert, who probably wrote most of this
>  and likely might have forgotten all of it)
>
> On Sat, 2014-06-21 at 15:17 +0200, Rickard Strandqvist wrote:
>> Adding missing code for managing a memory allocation error that may occur.
>>
>> This was partly found using a static code analysis program called cppcheck.
>
> skeletonfb.c is not meant to be compiled.
> It's a sample driver template.

Yep.

> Those /* goto error path */ lines are for
> driver writers that use this to figure out
> what to do.

Still, it's nice if a sample driver has correct error handling.
Just comments are not good enough as guidance for some people ;-)

> The second return is not correct as it would
> not free the first alloc'd block.

Indeed. Better do it right.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/