Re: [PATCH v3] sched: balance_cpu to consider other cpus in itsgroup as target of (pinned) task

From: Peter Zijlstra
Date: Thu Jun 21 2012 - 04:34:35 EST


On Thu, 2012-06-21 at 09:10 +0530, Srivatsa Vaddagiri wrote:

> Hmm ..I can see loop_break being incremented here:
>
> /* take a breather every nr_migrate tasks */
> if (env->loop > env->loop_break) {
> env->loop_break += sched_nr_migrate_break;
> env->flags |= LBF_NEED_BREAK;
> goto out;
> }
>
> As a result, when we redo with a different src_cpu, both loop and
> loop_break could be at non-default values. Am I missing something here?

D'0h right you are.. /me quickly edits patch again.

I thought I removed all that, guess I didn't.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/