Re: [PATCH v3] sched: balance_cpu to consider other cpus in its groupas target of (pinned) task

From: Prashanth Nageshappa
Date: Thu Jun 21 2012 - 01:26:14 EST


On 06/21/2012 09:53 AM, Srivatsa Vaddagiri wrote:

> * Srivatsa Vaddagiri <vatsa@xxxxxxxxxxxxxxxxxx> [2012-06-21 09:10:59]:
>
>> Hmm ..I can see loop_break being incremented here:
>>
>> /* take a breather every nr_migrate tasks */
>> if (env->loop > env->loop_break) {
>> env->loop_break += sched_nr_migrate_break;
>
> One possibility is to reset env->loop here, rather than loop_break, in
> which case loop_break can remain constant across "redos" and
> "more_balances"

We cannot do this as env->loop is compared with env->loop_max. So, I
believe resetting env->loop_break along with env->loop before "redos"
and "more_balances" is the right thing to do.

- Prashanth

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/