Re: [PATCH 1/1] exec: do not sleep in TASK_TRACED under ->cred_guard_mutex

[David Howells]

Oleg Nesterov <oleg@xxxxxxxxxx> wrote:

> 	- install_exec_creds() drops the mutex after commit_creds(),
> 	  and thus before tracehook_report_exec()->ptrace_stop().

Thanks!

> -
> -	/* cred_guard_mutex must be held at least to this point to prevent
> -	 * ptrace_attach() from altering our determination of the task's
> -	 * credentials; any time after this it may be unlocked */
> -

Why are you removing this comment, btw?  In what way does your patch
invalidate it?

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/