Re: [PATCH 1/1] exec: do not sleep in TASK_TRACED under->cred_guard_mutex

[Oleg Nesterov]

On 09/04, David Howells wrote:
>
> Oleg Nesterov <oleg@xxxxxxxxxx> wrote:
>
> > -
> > -	/* cred_guard_mutex must be held at least to this point to prevent
> > -	 * ptrace_attach() from altering our determination of the task's
> > -	 * credentials; any time after this it may be unlocked */
> > -
>
> Why are you removing this comment, btw?  In what way does your patch
> invalidate it?

No, the comment is fine. Except, now we have more users of this mutex,
but it only mentions ptrace_attach(). Tried to improve it, but failed
to make the concise and understandable comment,

I tried to collect all comments aboout cred_guard_mutex in one place,
above prepare_bprm_creds()... OK, agreed. Will revert this bit and
resend.

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/