Re: [patch 16/33] fs: dcache per-bucket dcache hash locking

From: Daniel Walker
Date: Fri Sep 04 2009 - 10:51:41 EST


On Fri, 2009-09-04 at 16:51 +1000, npiggin@xxxxxxx wrote:
> +/* This should be called _only_ with a lock pinning the dentry */
> +static inline struct dentry * __dget_locked_dlock(struct dentry
> *dentry)
> +{
> + dentry->d_count++;
> + dentry_lru_del_init(dentry);
> + return dentry;
> +}
> +
> +static inline struct dentry * __dget_locked(struct dentry *dentry)
> +{

Could you run your series through checkpatch, and clean up at least any
errors you find.. Plus add your signed off, most (all?) aren't signed
off..

Daniel

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/