Re: [GIT PULL] xen: swiotlb support for Xen dom0

From: Ingo Molnar
Date: Fri May 08 2009 - 07:20:30 EST



* Jeremy Fitzhardinge <jeremy@xxxxxxxx> wrote:

> Hi Ingo,
>
> This branch adds the swiotlb hooks for Xen dom0. We use swiotlb to handle
> various device drivers which assume that multipage DMA transfers which are
> contigious in kernel memory are also contigious in machine memory (mostly
> lower-performance devices, as high-performance ones already do a good job
> of scatter-gather).
>
> Following Fujita's suggestion, these changes remove a lot of the
> placeholder stubs in arch/x86/kernel/pci-swiotlb.c and moves them into
> the Xen-specific arch/x86/xen/pci-swiotlb.c. (It still relies on
> overriding the weak functions defined in lib/swiotlb.c.)
>
> The following changes since commit 2af252ab26150b4411889c9eaf1af4c5bf03de78:
> Jeremy Fitzhardinge (1):
> xen: checkpatch cleanups
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/jeremy/xen.git xen-tip/for-ingo/dom0/swiotlb
>
> Ian Campbell (4):
> xen swiotlb: fixup swiotlb is chunks smaller than MAX_CONTIG_ORDER
> xen: add hooks for mapping phys<->bus addresses in swiotlb
> xen/swiotlb: add swiotlb_arch_range_needs_mapping hook for xen
> xen: enable swiotlb for xen domain 0.
>
> Jeremy Fitzhardinge (5):
> xen: make sure swiotlb allocation is physically contigious
> swiotlb: use swiotlb_alloc_boot to allocate emergency pool
> xen/swiotlb: improve comment on gfp flags in xen_alloc_coherent()
> xen/swiotlb: add sync functions
> xen/swiotlb: update to new new dma_ops
>
> arch/x86/kernel/pci-swiotlb.c | 30 ++--------
> arch/x86/xen/Kconfig | 1 +
> arch/x86/xen/Makefile | 1 +
> arch/x86/xen/pci-swiotlb.c | 53 ++++++++++++++++++
> drivers/pci/xen-iommu.c | 123 +++++++++++++++++++++++++++++------------
> include/xen/swiotlb.h | 18 ++++++
> lib/swiotlb.c | 3 +-
> 7 files changed, 168 insertions(+), 61 deletions(-)
> create mode 100644 arch/x86/xen/pci-swiotlb.c
> create mode 100644 include/xen/swiotlb.h

Ok, this looks good to me at a quick glance and it makes quite a bit
of sense - but it would be nice to get the acks (or reviewed-by
tags) of Fujita-san and Joerg, and address any review feedback and
if everything is resolved, propagate those tags into the series.

Thanks,

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/