Re: [GIT PULL] xen: swiotlb support for Xen dom0

From: FUJITA Tomonori
Date: Sun May 10 2009 - 23:42:39 EST


On Thu, 7 May 2009 17:17:13 -0700
Jeremy Fitzhardinge <jeremy@xxxxxxxx> wrote:

> Hi Ingo,
>
> This branch adds the swiotlb hooks for Xen dom0. We use swiotlb to handle
> various device drivers which assume that multipage DMA transfers which are
> contigious in kernel memory are also contigious in machine memory (mostly
> lower-performance devices, as high-performance ones already do a good job
> of scatter-gather).
>
> Following Fujita's suggestion, these changes remove a lot of the
> placeholder stubs in arch/x86/kernel/pci-swiotlb.c and moves them into
> the Xen-specific arch/x86/xen/pci-swiotlb.c.

Yeah, all Xen-specific stuff should live in the Xen land. The changes
to non-Xen code (like arch/x86/kernel/pci-swiotlb.c) look fine to me.


> (It still relies on
> overriding the weak functions defined in lib/swiotlb.c.)

As I said before, I don't like such weak hacks added for dom0. We will
merge dom0 support?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/