Re: [PATCH] improve OProfile on many-way systems

From: John Levon
Date: Sat Aug 21 2004 - 18:23:02 EST


On Sat, Aug 21, 2004 at 01:58:33PM -0700, Andrew Morton wrote:

> > Anton prompted me to get this patch merged. It changes the core buffer
> > sync algorithm of OProfile to avoid global locks wherever possible.
> > Anton tested an earlier version of this patch with some success. I've
> > lightly tested this applied against 2.6.8.1-mm3 on my two-way machine.
>
> OK. Oprofile isn't the most commonly tested part of the kernel. Given
> that you've "lightly tested" it,

I hammered the patch with earlier kernel versions for some time a while
ago. But that was on a 2-way, which hardly counts as proper testing.

> how do we know when it has had sufficient testing for its swim upstream?

I thought one of the points of the mm tree was to give things some
testing first.

> Does Philippe have some test suite, perhaps?

He doesn't have access to any SMP machines at all, last I heard.

regards
john
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/