Re: [PATCH] improve OProfile on many-way systems

From: John Levon
Date: Mon Aug 23 2004 - 19:29:50 EST


On Sun, Aug 22, 2004 at 02:34:00PM +1000, Anton Blanchard wrote:

> > That must be profile_rwsem in kernel/profile.c since the rest of the
> > code won't be doing anything. I imagine it needs RCUing.
>
> Also profile_hook is called in the interrupt handler and has a global
> spinlock (profile_lock). If the notifier hooks used RCU then we wouldnt
> need this lock.

If that were the problem he'd see it with profile=2 though, since it
uses the same mechanism... should still be fixed of course.

john
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/