Re: Merge I2O patches from -mm

[Christoph Hellwig]

> > add a controller_add and add controller_remove method, taking a typesafe
> > i2o_controller * instead of the multiplexer.
> 
> I had this before, but i want the notification also for I2O devices, 
> because the driver model won't call probe functions for devices, which 
> are already occupied by a other driver.

Then please add more methods.  Multiplexer calls are an extremly bad idea.

> This is not the best solution, 
> if you have more then one drivers which could handle a device. This is 
> the case in e.g. i2o_proc, which only want to display information, and 
> is not a "real driver". So finally there will be controller_add, 
> controller_remove, device_add, device_remove... and i thought it would 
> be more generic, and i also don't have to add a function each time a new 
> notification is needed :-)

Yes, that's the whole point of this methods..

> Also i tried to implement the notification like the one already in the 
> kernel, so i could exchange my notification facility with the already 
> existing one (include/linux/notifier.h)...

linux/notifier.h is an bad example to follow and for many thing we're
moving slowly away from it (e.g. the shutdown notifications are now
exposed through the driver model)

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/