Re: 2.6.2-rc2-bk1 oopses on boot (ACPI patch)

From: Linus Torvalds
Date: Tue Jan 27 2004 - 22:08:30 EST




On Wed, 28 Jan 2004, Alessandro Suardi wrote:
>
> Already reported, but I'll do so once again, since it looks like
> in a short while I won't be able to boot official kernels in my
> current config...
>
> http://www.ussg.iu.edu/hypermail/linux/kernel/0312.3/0442.html

Can you make adjust_jiffies() print out its arguments (it's in
drivers/cpufreq/cpufreq.c).

It looks like cpufreq_scale() gets a divide-by-zero or an overflow on one
of

l_p_j_ref, l_p_j_ref_freq, ci->new

and just printing out those values would be interesting.

That said, the code is crap anyway. It does various divides without
actually testing for any sanity at all, and tries to "avoid overflow" by
totally bogus methods, instead of just using the 64-bit do_div64().

Dominic? Dave? Suggestions about nicer failure modes?

Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/