Re: ANNOUNCE: megaraid driver version 2.10.1

['hch@xxxxxxxxxxxxx']

On Tue, Jan 13, 2004 at 04:39:12PM -0500, Mukker, Atul wrote:
> The changes in 2.6.1 are rather extensive, so it would be sometime before
> kernel 2.6.1 version of megaraid is sync'ed against megaraid-2.10.1. Also,
> we would like to backport the PCI hotplug changes to 2.4.x kernel megaraid
> as well.

The problem with backporting is that the 2.4 scsi layer is not hot-plug aware,
so while you can make the driver detect a newly inserted or removed HBA there's
no way to tell the SCSI midlayer.

> +#ifdef SCSI_HAS_HOST_LOCK
> +#  if LINUX_VERSION_CODE <= KERNEL_VERSION(2,4,9)
> +		/* This is the Red Hat AS2.1 kernel */
> +		adapter->host_lock = &adapter->lock;
> +		host->lock = adapter->host_lock;
> +#  elif LINUX_VERSION_CODE < KERNEL_VERSION(2,6,0)
> +		/* This is the later Red Hat 2.4 kernels */
> +		adapter->host_lock = &adapter->lock;
> +		host->host_lock = adapter->host_lock;
> +#  else
> +		/* This is the 2.6 and later kernel series */
> +		adapter->host_lock = &adapter->lock;
> +		scsi_set_host_lock(&adapter->lock);
> +#  endif
> +#else
> +		/* And this is the remainder of the 2.4 kernel series */
>  		adapter->host_lock = &io_request_lock;
> +#endif

This is horribly ugly, but not your faul.  Any chance you could hide
it into some macro ala megaraid_set_host_lock(adapter, host).

Also note that in 2.6 scsi_set_host_lock should and could easily be avoided,
just let your adapter->host_lock point to host->host_lock.

>  		if((adapter->flag & BOARD_64BIT)&&(sizeof(dma_addr_t) == 8))
> {
> -			pci_set_dma_mask(pdev, 0xffffffffffffffff);
> +			pci_set_dma_mask(pdev, 0xffffffffffffffffULL);

This needs error return checking.  Again this no regression from the previous
version, could you please fix it in the next update?

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/