Re: [PATCH] module load notification try 2

From: Rusty Russell (rusty@rustcorp.com.au)
Date: Mon Mar 24 2003 - 23:01:47 EST


In message <20030325011525.GA92370@compsoc.man.ac.uk> you write:
> > Otherwise there's no way to sanely use them without wrapping in #ifdef
>
> Well, "if (err && err != -ENOSYS)". The relative sanity of that is
> debatable. I don't care either way, hence the coin toss.

OK, well, I have an opinion and it's the other one. 8)

> > Hmm, yes, you need to use your own protection around
> > notifier_chain_register and notifier_call_chain. Wierd, because
> > notifier.c does its own locking for register and unregister, but not
> > for calling, which AFAICT makes it useless...
>
> I mentioned about this some time ago on lkml to massive indifference.

Yeah, it's a PITA.

Cheers,
Rusty.

--
  Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Mon Mar 31 2003 - 22:00:19 EST