Re: crc32 cleanups

From: Jeff Garzik (
Date: Fri Oct 12 2001 - 14:37:52 EST

More comments:
* if ether_crc is always == ether_crc_be, then create a #define instead
  of patching driver code
* no need to inline ether_crc_be, stick it in lib/crc32.c also
* using a ref-counting init_crc32 and cleanup_crc32, you do not need
  CONFIG_xxx tests, per driver, in the code itself. Either make
  lib/crc32 a permanent part of the kernel, or make it a separate module
  which is enabled by makefile rules. Example:

obj-$(CONFIG_TULIP) += crc32.o
obj-$(CONFIG_NATSEMI) += crc32.o
obj-$(CONFIG_DMFE) += crc32.o
obj-$(CONFIG_ANOTHERDRIVER) += crc32.o

makefile rules eliminate the duplicates...

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

This archive was generated by hypermail 2b29 : Mon Oct 15 2001 - 21:00:46 EST