Re: kapm-idled Funny in 2.4.10-ac12

From: Thomas Hood (
Date: Fri Oct 12 2001 - 14:40:24 EST

Just taking a walk through apm.c ...

I notice that set_time() calls get_cmos_time() with interrupts
disabled, whereas get_time_diff calls it with interrupts

get_cmos_time is in time.c . It does a bunch of CMOS_READs
without taking rtc_lock.

Methinks that the
    save_flags(flags); ...; cli(); ...; restore_flags(flags);
constructs in apm.c need some attention.


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

This archive was generated by hypermail 2b29 : Mon Oct 15 2001 - 21:00:46 EST