Re: crc32 cleanups

From: Keith Owens (
Date: Fri Oct 12 2001 - 20:51:17 EST

On Fri, 12 Oct 2001 14:37:52 -0500 (CDT),
Jeff Garzik <> wrote:
>obj-$(CONFIG_TULIP) += crc32.o
>obj-$(CONFIG_NATSEMI) += crc32.o
>obj-$(CONFIG_DMFE) += crc32.o
>obj-$(CONFIG_ANOTHERDRIVER) += crc32.o

It is better to define CONFIG_CRC32 and have the files set
CONFIG_CRC32 for selected drivers. That avoids the problem of lots of
drivers wanting to patch the same Makefile, instead the selection of
crc32 is kept with the driver selection.

obj-$(CONFIG_CRC32) += crc32.o

if [ "$CONFIG_FOO" = "y" ]; then
  define_bool CONFIG_CRC32 y

It is even cleaner in CML2.
require FOO implies CRC32=y

In general it is a bad idea to handle selections in the Makefile, that
is what CML is for. Makefiles should just build the code based on CML
output, not try to decide what to build.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

This archive was generated by hypermail 2b29 : Mon Oct 15 2001 - 21:00:47 EST