On Thu, 9 Nov 2000, Jens Axboe wrote:
>
> > The second is more elegant in that it side steps the problem by
> > giving rd.c a make_request function instead of using the default
> > _make_request. This means that io_request_lock is simply never
> > claimed my rd.
>
> And this solution is much better, even given the freeze I think that
> is the way to go.
I agree, I already applied it. The second approach just makes the problem
go away, and also avoids needlessly merging the request etc. I suspect
that the lack of request-merging could also eventually be used to simplify
the driver a bit, as it now wouldn't need to worry about that issue any
more at all.
Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Wed Nov 15 2000 - 21:00:14 EST