On Sat, 13 May 2000 00:55:57 +0100 (BST), Russell King wrote:
> Maybe you should do what all the other drivers do and include linux/fs.h
> before linux/sound.h, by some means?
That's how I solved it.
> Are you sure that about 158 extra #include statements and associated
> newlines for the C preprocessor and compiler is better than a simple
The sound drivers have to include it anyway, so *technically* spoken it
doesn't really matter where it is included. However, from a *convenience*
point of view, it is handy that linux/sound.h should include it. The fact
that linux/fs.h needs a cleanup should not be a reason to avoid including
it in a sound driver; we should fix the source of the problems, not cure
its effects (but we'll leave it until 2.5).
Erik
-- J.A.K. (Erik) Mouw, Information and Communication Theory Group, Department of Electrical Engineering, Faculty of Information Technology and Systems, Delft University of Technology, PO BOX 5031, 2600 GA Delft, The Netherlands Phone: +31-15-2783635 Fax: +31-15-2781843 Email: J.A.K.Mouw@its.tudelft.nl WWW: http://www-ict.its.tudelft.nl/~erik/- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Mon May 15 2000 - 21:00:25 EST