Re: [patch] 3c59x.c

From: Andrew Morton (andrewm@uow.edu.au)
Date: Tue May 02 2000 - 02:30:31 EST


Andreas Tobler wrote:
>
> Tom Rini wrote:
> > >
> > >
> > > John and Andreas are currently working on the ppc byte ordering issues
> > > with this driver. As far as I know, it is currently in the "not known
> > > to work on PPC" state. If you are able to debug, test or otherwise
> > > help them sort it out it would be truly great!
> >
> > Erm. When did this break? The driver in 2.2.15pre20 is working quite happily
> > in my G4 on a 3c905B.
>
> A stock 3c59x.c with the insl_ns/outsl_ns should work with 2215p20.
> The break happens for me in Andrews patch from 22.4. I can't get it to
> run it leads to a 'freeze'. But right now??

Andreas is talking about the 2.2 patch, BTW.
http://www.uow.edu.au/~andrewm/linux/#3c59x-2.2

And the breakage is on the Vortex chip, 3c590 - this is significant
because it uses rather different code paths.

And ooolookydat:

#define EISA_TBL_OFFSET 5
  
should have been 6!

There was a magic and very fragile "4" emedded in the driver. I turned
it into this #define and miscounted. 2.3 is OK.

Guys, please try this, let me know? If someone can test the 2.3 driver
as well?

insl & outsl are only used in one place, BTW.

-- 
-akpm-

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sun May 07 2000 - 21:00:09 EST