Re: small patch for pty.c

From: willy@thepuffingroup.com
Date: Tue Apr 18 2000 - 11:27:49 EST


On Tue, Apr 18, 2000 at 12:48:53PM +0200, Jamie Lokier wrote:
> Linus Torvalds wrote:
> > MIN() is a _bad_ thing to use. It _always_ gets the sign wrong. Sorry, but
> > that's how it is. It makes people think that "oh, it takes the minimum of
> > two numbers" and at the same time it makes people completely forget
> > signedness issues.
>
> GCC -Wall warns about comparisons between signed and unsigned.
> Is that not good enough?

the header files need to be cleaned up in order to be able to use -Wall
without getting scads of bogus warnings. Some of that work has been
done but not all of it. I'll get to it sometime if no-one beats me to it.
(hint, it's the signal delivery stuff).

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sun Apr 23 2000 - 21:00:13 EST