Re: small patch for pty.c

From: Jamie Lokier (lk@tantalophile.demon.co.uk)
Date: Tue Apr 18 2000 - 05:48:53 EST


Linus Torvalds wrote:
> MIN() is a _bad_ thing to use. It _always_ gets the sign wrong. Sorry, but
> that's how it is. It makes people think that "oh, it takes the minimum of
> two numbers" and at the same time it makes people completely forget
> signedness issues.

GCC -Wall warns about comparisons between signed and unsigned.
Is that not good enough?

-- Jamie

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sun Apr 23 2000 - 21:00:12 EST