Re: small patch for pty.c

From: Kai Henningsen (kaih@khms.westfalen.de)
Date: Wed Apr 19 2000 - 02:41:00 EST


willy@thepuffingroup.com wrote on 18.04.00 in <20000418122749.W15697@thepuffingroup.com>:

> On Tue, Apr 18, 2000 at 12:48:53PM +0200, Jamie Lokier wrote:
> > Linus Torvalds wrote:
> > > MIN() is a _bad_ thing to use. It _always_ gets the sign wrong. Sorry,
> > > but that's how it is. It makes people think that "oh, it takes the
> > > minimum of two numbers" and at the same time it makes people completely
> > > forget signedness issues.
> >
> > GCC -Wall warns about comparisons between signed and unsigned.
> > Is that not good enough?
>
> the header files need to be cleaned up in order to be able to use -Wall
> without getting scads of bogus warnings.

I thought the kernel *is* compiled with -Wall, and has been for a long
time? And I certainly don't remember scads of bogus warnings from kernel
compiles. (Incidentally, the same is true for my userland compiles.)

>Some of that work has been
> done but not all of it. I'll get to it sometime if no-one beats me to it.
> (hint, it's the signal delivery stuff).

More details, please.

MfG Kai

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sun Apr 23 2000 - 21:00:14 EST